Skip to content

[codex] Structure missing client cloud config errors - #3346

Merged
juliusmarminge merged 2 commits into
mainfrom
codex/web-cloud-config-error
Jun 20, 2026
Merged

[codex] Structure missing client cloud config errors#3346
juliusmarminge merged 2 commits into
mainfrom
codex/web-cloud-config-error

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jun 20, 2026 •
edited by macroscopeapp Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • replace generic missing Clerk JWT template throws in web and mobile with Schema-tagged configuration errors
  • carry the missing public configuration key as structured data while preserving the existing message
  • avoid inventing a cause for a deterministic configuration validation failure
  • cover both client boundaries with focused tests

Validation

  • pnpm vp test apps/web/src/cloud/publicConfig.test.ts apps/mobile/src/features/cloud/publicConfig.test.ts (9 tests)
  • pnpm vp check (passes with existing repository warnings)
  • pnpm vp run typecheck
  • pnpm vp run lint:mobile

Note

Replace generic errors with structured CloudPublicConfigMissingError in web and mobile cloud config

Introduces CloudPublicConfigMissingError, a tagged error class (via effect/Schema), in both the web and mobile publicConfig modules. When resolveRelayClerkTokenOptions cannot find the Clerk JWT template, it now throws this structured error instead of a plain Error. Tests are added for both platforms to verify the new error type is thrown.

Macroscope summarized adbdcc0.

@juliusmarminge @codex
[codex] Structure missing web cloud config errors
fdc5ef6 
Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4e1c3943-49d0-4563-94fd-f3c73fbcf964

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/web-cloud-config-error

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jun 20, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 20, 2026
View reviewed changes
@macroscopeapp

macroscopeapp Bot commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR replaces generic Error throws with a structured CloudPublicConfigMissingError class in two locations. The error condition and message remain unchanged - this is purely a typing/structure improvement with added tests, carrying minimal risk.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge @codex
Structure missing mobile cloud config errors
adbdcc0 
Co-authored-by: codex <codex@users.noreply.github.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review June 20, 2026 14:58

Dismissing prior approval to re-evaluate adbdcc0

@juliusmarminge juliusmarminge changed the title [codex] Structure missing web cloud config errors [codex] Structure missing client cloud config errors Jun 20, 2026
@juliusmarminge
juliusmarminge merged commit f3b43a1 into main Jun 20, 2026
16 checks passed
@juliusmarminge
juliusmarminge deleted the codex/web-cloud-config-error branch June 20, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macroscopeapp macroscopeapp[bot] macroscopeapp[bot] approved these changes

Assignees

No one assigned

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge